feat: implement missing compose samples and fix library bugs#42
Open
feat: implement missing compose samples and fix library bugs#42
Conversation
…sh UI test baseline - Created a centralized samples catalog at the repository root for better discoverability, integrating the PlacesUIKit3D sample. - Created BasicComposeMapActivity from scratch to serve as a minimal pedagogical reference for Maps 3D Compose integration. - Established a baseline of UI smoke tests across key activities in both advanced and PlacesUIKit3D modules to ensure stability.
Created ComposeDemos module with skeletons, tests, and automation script. Reorganized catalog into module-specific READMEs.
Enabled immersive mode in all implemented activities and updated screenshots in catalog.
Implemented Polygons, Models, and Markers samples in Compose with visual tests and updated catalog.
Implemented Camera Restrictions sample in Compose with visual test and updated catalog.
kikoso
reviewed
Apr 24, 2026
| if (currentOnMapClick != null || currentOnPlaceClick != null) { | ||
| googleMap3D.setMap3DClickListener { _, placeId -> | ||
| googleMap3D.setMap3DClickListener { location, placeId -> | ||
| android.util.Log.d("GoogleMap3D", "Map clicked at $location, placeId: $placeId") |
Collaborator
There was a problem hiding this comment.
FQDN:
Suggested change
| android.util.Log.d("GoogleMap3D", "Map clicked at $location, placeId: $placeId") | |
| Log.d("GoogleMap3D", "Map clicked at $location, placeId: $placeId") |
Collaborator
|
LGTM. Should we implement the TODO of I have been running this on the device and checking the performance. There seems to be some increase in memory and/or leaks, but to be honest this seems attributable to the maps itself, not the implementation here. |
kikoso
approved these changes
Apr 24, 2026
- Fix ktlint property naming error in PlaceDetailsActivity - Add missing ProGuard rule files in snippets/common - Fix directory typo in build-advanced CI workflow
This resolves build failures during manifest merger tasks (like processDebugUnitTestManifest) which were missing the MAPS3D_API_KEY placeholder.
kikoso
force-pushed
the
feat/fillout-missing-samples
branch
from
208e707 to
fbd6d36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements missing Compose samples (Routes API, Camera Restrictions, etc.) and fixes a critical bug in the library regarding model updates. It also cleans up FQNs and adds unit tests.